bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr

[y***@gmail.com]

Number: 49005
Category: bin
Synopsis: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Confidential: no
Severity: non-critical
Priority: low
Responsible: bin-bug-people
State: open
Class: sw-bug
Submitter-Id: net
Arrival-Date: Thu Jul 17 05:40:00 +0000 2014
Originator: Garrett Cooper
Release: n/a

EMC / Isilon Storage Division
n/a
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

[Garrett Cooper]

The following reply was made to PR bin/49005; it has been noted by GNATS.

From: Garrett Cooper <***@gmail.com>
To: "gnats-***@NetBSD.org" <gnats-***@netbsd.org>
Cc:
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Wed, 16 Jul 2014 22:43:41 -0700

--047d7bdc07e28629e704fe5d1fde
Content-Type: text/plain; charset=UTF-8

Thank you very much for your problem report.
It has the internal identification `bin/49005'.
The individual assigned to look at your
report is: bin-bug-people.

Category: bin
Responsible: bin-bug-people
Synopsis: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Arrival-Date: Thu Jul 17 05:40:00 +0000 2014

Patch attached -- thanks!
-Garrett

--047d7bdc07e28629e704fe5d1fde
Content-Type: application/octet-stream;
name="t_truncate-use-etc-motd-instead-of-fpc.patch"
Content-Disposition: attachment;
filename="t_truncate-use-etc-motd-instead-of-fpc.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_hxpnjyj80

SW5kZXg6IHRlc3RzL2xpYi9saWJjL3N5cy90X3RydW5jYXRlLmMKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls
ZTogL2N2c3Jvb3Qvc3JjL3Rlc3RzL2xpYi9saWJjL3N5cy90X3RydW5jYXRlLmMsdgpyZXRyaWV2
aW5nIHJldmlzaW9uIDEuMgpkaWZmIC11IC1yMS4yIHRfdHJ1bmNhdGUuYwotLS0gdGVzdHMvbGli
L2xpYmMvc3lzL3RfdHJ1bmNhdGUuYwkxOCBBdWcgMjAxMSAxOTo0ODowMyAtMDAwMAkxLjIKKysr
IHRlc3RzL2xpYi9saWJjL3N5cy90X3RydW5jYXRlLmMJMTcgSnVsIDIwMTQgMDQ6NDM6MDEgLTAw
MDAKQEAgLTE2MCw3ICsxNjAsNyBAQAogCUFURl9SRVFVSVJFX0VSUk5PKEVOT0VOVCwgdHJ1bmNh
dGUoIi9hL2IvYy9kL2UvZi9nIiwgOTk5KSA9PSAtMSk7CiAKIAllcnJubyA9IDA7Ci0JQVRGX1JF
UVVJUkVfRVJSTk8oRUFDQ0VTLCB0cnVuY2F0ZSgiL3Vzci9iaW4vZnByIiwgOTk5KSA9PSAtMSk7
CisJQVRGX1JFUVVJUkVfRVJSTk8oRUFDQ0VTLCB0cnVuY2F0ZSgiL2V0Yy9tb3RkIiwgOTk5KSA9
PSAtMSk7CiB9CiAKIEFURl9UUF9BRERfVENTKHRwKQo=
--047d7bdc07e28629e704fe5d1fde--

[David Holland]

The following reply was made to PR bin/49005; it has been noted by GNATS.

From: David Holland <dholland-***@netbsd.org>
To: gnats-***@NetBSD.org
Cc:
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
/usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000

Post by y***@gmail.com
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

--
David A. Holland
***@netbsd.org

[Garrett Cooper]

Post by Garrett Cooper
The following reply was made to PR bin/49005; it has been noted by GNATS.
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
/usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000

Post by y***@gmail.com
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

Ah, ok. It might be better to install a file into the source
directory that's owned by root and 0644, then try and truncate it so
the test is more portable and doesn't accidentally hose a utility or
other file that it shouldn't as that's the purpose of the testcase (to
test EACESS). Does that sound like a good approach?
Thanks!
-Garrett

[Garrett Cooper]

Post by Garrett Cooper

Post by Garrett Cooper
The following reply was made to PR bin/49005; it has been noted by GNATS.
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
/usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000

Post by y***@gmail.com
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

Ah, ok. It might be better to install a file into the source

source -> tests

Post by Garrett Cooper
directory that's owned by root and 0644, then try and truncate it so
the test is more portable and doesn't accidentally hose a utility or
other file that it shouldn't as that's the purpose of the testcase (to
test EACESS). Does that sound like a good approach?

[Garrett Cooper]

The following reply was made to PR bin/49005; it has been noted by GNATS.

From: Garrett Cooper <***@gmail.com>
To: "gnats-***@NetBSD.org" <gnats-***@netbsd.org>
Cc: "gnats-***@netbsd.org" <gnats-***@netbsd.org>,
"netbsd-***@netbsd.org" <netbsd-***@netbsd.org>
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Thu, 17 Jul 2014 12:19:16 -0700

Post by Garrett Cooper
The following reply was made to PR bin/49005; it has been noted by GNATS.
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
/usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000

Post by y***@gmail.com
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

Ah, ok. It might be better to install a file into the source
directory that's owned by root and 0644, then try and truncate it so
the test is more portable and doesn't accidentally hose a utility or
other file that it shouldn't as that's the purpose of the testcase (to
test EACESS). Does that sound like a good approach?
Thanks!
-Garrett

[Garrett Cooper]

The following reply was made to PR bin/49005; it has been noted by GNATS.

From: Garrett Cooper <***@gmail.com>
To: "gnats-***@NetBSD.org" <gnats-***@netbsd.org>
Cc: "gnats-***@netbsd.org" <gnats-***@netbsd.org>,
"netbsd-***@netbsd.org" <netbsd-***@netbsd.org>
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Thu, 17 Jul 2014 12:19:42 -0700

Post by Garrett Cooper

Post by Garrett Cooper
The following reply was made to PR bin/49005; it has been noted by GNATS.
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
/usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000

Post by y***@gmail.com
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

Ah, ok. It might be better to install a file into the source

source -> tests

Post by Garrett Cooper
directory that's owned by root and 0644, then try and truncate it so
the test is more portable and doesn't accidentally hose a utility or
other file that it shouldn't as that's the purpose of the testcase (to
test EACESS). Does that sound like a good approach?

[Garrett Cooper]

Post by Garrett Cooper
The following reply was made to PR bin/49005; it has been noted by GNATS.
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Thu, 17 Jul 2014 12:19:42 -0700

Post by Garrett Cooper

Post by Garrett Cooper
The following reply was made to PR bin/49005; it has been noted by GNATS.
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000

Post by y***@gmail.com
FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so the testcase should be changed to use /etc/motd.

/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

Ah, ok. It might be better to install a file into the source

source -> tests

Post by Garrett Cooper
directory that's owned by root and 0644, then try and truncate it so
the test is more portable and doesn't accidentally hose a utility or
other file that it shouldn't as that's the purpose of the testcase (to
test EACESS). Does that sound like a good approach?

FILESGROUPS= FILES truncate_test_FILES
truncate_test_FILES= truncate_test.root_owned
truncate_test_FILESDIR= ${TESTSDIR}
truncate_test_FILESMODE= 0600
truncate_test_FILESOWNER= root
truncate_test_FILESGRP= wheel
CLEANFILES= truncate_test.root_owned
dd if=/dev/null bs=1 count=1 of=${.TARGET}

Cheers!

[Garrett Cooper]

The following reply was made to PR bin/49005; it has been noted by GNATS.

From: Garrett Cooper <***@gmail.com>
To: gnats-***@NetBSD.org
Cc: gnats-***@netbsd.org,
netbsd-***@netbsd.org
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Thu, 23 Oct 2014 22:22:42 -0700

--Apple-Mail=_7B7B5186-365F-4402-886D-C9A915C9667F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252

The following reply was made to PR bin/49005; it has been noted by =

GNATS.

=20
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of =

/usr/bin/fpr

Date: Thu, 17 Jul 2014 12:19:42 -0700
=20
On Thu, Jul 17, 2014 at 12:19 PM, Garrett Cooper =

On Thu, Jul 17, 2014 at 2:10 AM, David Holland =

The following reply was made to PR bin/49005; it has been noted by =

GNATS.

=20
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
/usr/bin/fpr
Date: Thu, 17 Jul 2014 09:05:40 +0000
=20

FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so =

the testcase should be changed to use /etc/motd.

=20
/usr/bin/fpr was chosen on the grounds that it's expendable if
something goes wrong and it gets truncated. The motd isn't.

=20
Ah, ok. It might be better to install a file into the source

=20
source -> tests
=20

directory that's owned by root and 0644, then try and truncate it so
the test is more portable and doesn't accidentally hose a utility or
other file that it shouldn't as that's the purpose of the testcase =

(to

test EACESS). Does that sound like a good approach?

Here=92s a better approach: =
https://svnweb.freebsd.org/base?view=3Drevision&revision=3D273533 ; =
here=92s the build target I=92ll be adding to =

FILESGROUPS=3D FILES truncate_test_FILES
truncate_test_FILES=3D truncate_test.root_owned
truncate_test_FILESDIR=3D ${TESTSDIR}
truncate_test_FILESMODE=3D 0600
truncate_test_FILESOWNER=3D root
truncate_test_FILESGRP=3D wheel
CLEANFILES=3D truncate_test.root_owned
dd if=3D/dev/null bs=3D1 count=3D1 of=3D${.TARGET}

Cheers!

--Apple-Mail=_7B7B5186-365F-4402-886D-C9A915C9667F
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJUSeIiAAoJEMZr5QU6S73eMHwH/RXDnurQL4Y7xKBgbFZi2H7r
YyWve9IL3UGye7GYmk/FfR4baFwiDIVelbnIktAzSd9uOPpHWX2+OHRMOjQ+gyFn
sXen6+PI2EuwYe9sjCV8FpaF8UZTxSnuuM+mP7ZvSmNPvq+fqDm4fuxrgJ4KmE1g
7jmGlB5FwulxCdETTIl6yV73tERSRCPsW7KJVn+69cyYRGFTTDR/fjqF64beQfGW
PlXgHUYT0pKD9hLtdAgUBYhV0GhLyHGXcfaR784ASs2d1U9PBca99McquHwpYN/3
xdGvVnY87d7JfPVHTIDpfO1TdkI8T9ee9v402PhyEX3JoXM4JnXCpjtHw6lZrJQ=
=XE1r
-----END PGP SIGNATURE-----

--Apple-Mail=_7B7B5186-365F-4402-886D-C9A915C9667F--